bin/setup uses rm instead of npm prune

OSC / ood-fileexplorer

[MOVED] The Open OnDemand File Explorer

https://osc.github.io/Open-OnDemand/

MIT License

4 stars 1 forks source link

bin/setup uses rm instead of npm prune #176

Closed brianmcmichael closed 6 years ago

brianmcmichael commented 6 years ago

Use rm -rf instead of npm prune
Changelog formatting updates

nickjer commented 6 years ago

Have you tested if an npm install with a different version of npm will be smart enough to rebuild the previously built node_modules? I doubt it is that smart, but if by chance it is, then this PR is not needed.

UPDATE: Tested it, and it failed. So removing the node_modules completely is the only way to rebuild the packages with a newer version of node.