Add progress messages

[MorganRodgers]

Adds progress messages.

[MorganRodgers]

Note that this (and its parent branch) is an alternative to #202.

[ericfranz]

If i copy one directory recursively this will show:

100%

And then execute the recursive copy, right? Only if I select two different files and then click copy and then paste will it do 50% then 50%.

Should we just remove progress messages altogether?

Did you verify this and the other both work for you on our systems?

[MorganRodgers]

If i copy one directory recursively this will show:

100%

And then execute the recursive copy, right? Only if I select two different files and then click copy and then paste will it do 50% then 50%.

Should we just remove progress messages altogether?

Did you verify this and the other both work for you on our systems?

I do not believe so no, because it generates a list of files to copy first so you have the full length of the copy operations necessary to start with.

I have verified that the code generates increasing progress messages both when copying directories and when copying 'a handful of files'. Did you actually see the behavior you are describing?

[johrstrom]

I'm getting this error while pasting a single file to a single location.

App 7247 output: ^M copy   %
App 7247 output: /users/PZS0714/johrstrom/ondemand/dev/ood-fileexplorer/lib/cloudcmd/lib/server/rest.js:354
App 7247 output:         ).finally(
App 7247 output:                  ^
App 7247 output: 
App 7247 output: TypeError: Promise.all(...).catch(...).finally is not a function
App 7247 output:     at copy (/users/PZS0714/johrstrom/ondemand/dev/ood-fileexplorer/lib/cloudcmd/lib/server/rest.js:354:18)
App 7247 output:     at onPUT (/users/PZS0714/johrstrom/ondemand/dev/ood-fileexplorer/lib/cloudcmd/lib/server/rest.js:246:21)
App 7247 output:     at /users/PZS0714/johrstrom/ondemand/dev/ood-fileexplorer/lib/cloudcmd/lib/server/rest.js:112:25
App 7247 output:     at IncomingMessage.onEnd (/users/PZS0714/johrstrom/ondemand/dev/ood-fileexplorer/lib/cloudcmd/node_modules/pipe-io/lib/pipe.js:203:13)
App 7247 output:     at emitNone (events.js:86:13)
App 7247 output:     at IncomingMessage.emit (events.js:185:7)
App 7247 output:     at endReadableNT (_stream_readable.js:974:12)
App 7247 output:     at _combinedTickCallback (internal/process/next_tick.js:80:11)
App 7247 output:     at process._tickCallback (internal/process/next_tick.js:104:9)
[ W 2019-08-27 09:39:32.8662 130752/T9 age/Cor/Con/InternalUtils.cpp:96 ]: [Client 2-1566] Sending 502 response: application did not send a complete response

[ericfranz]

Oh, finally is not in node.js!

[MorganRodgers]

@johrstrom would you please pull origin and test this one more time to see if you get the same error as before?

[johrstrom]

Yea it works for me.

That said, I hate to be 'that guy' but it doesn't show progress numbers to me on FF/linux. It Does on Edge/windows and chrome/windows though.

[ericfranz]

Shows for me on FF OS X..

[MorganRodgers]

Thanks. @johrstrom we need 'that guy'. Any error messages in the console? Are the progress messages ending up in the NGINX error log?

[johrstrom]

only this. It doesn't work for copying a single file to a single location or copying a directory to a singe location. I'm updating but only from 68.0 to 68.0.2.

[ N 2019-08-27 10:54:09.4787 23044/T5 age/Cor/SecurityUpdateChecker.h:519 ]: Security update check: no update found (next check in 24 hours)
App 23067 output: [2019-08-27 10:54:09 -0400 ]  INFO "method=GET path=/pun/sys/dashboard/ format=html controller=DashboardController action=index status=200 duration=515.43 view=186.46"
 copy   % output: 
App 23196 output: 
 copy   % output: 
App 23196 output: 
 copy   % output: 
App 23196 output: 
 copy   % output: 
App 23196 output: 
 copy   % output: 
App 23196 output: 

[johrstrom]

Actually, sorry, opened in a private window and it started working. Must have cached something, sorry for the confusion.

[MorganRodgers]

Oh, good.

Also: https://shouldiblamecaching.com/

[MorganRodgers]

So, then the question is @ericfranz does this solve the problem that Lustre users experience?

[MorganRodgers]

IRL response from @ericfranz is that this does not fix the issue for Lustre users. Therefore closing.