search

OSC / ood-fileexplorer

[MOVED] The Open OnDemand File Explorer
https://osc.github.io/Open-OnDemand/
MIT License
4 stars 1 forks source link

Icons not displaying in IE11 #91

Closed brianmcmichael closed 8 years ago

brianmcmichael commented 8 years ago

Fontello icons not displaying properly in deployed fileexplorer on IE 11

badicons

brianmcmichael commented 8 years ago

@nickjer I will need your assistance on this. Alternatively, I will need to find glyphicon replacements and locations of all of the icons in the app.

From the fontello source:

https://github.com/fontello/fontello/tree/master/support/font-templates

Attention for server setup
--------------------------

You MUST setup server to reply with proper `mime-types` for font files -
otherwise some browsers will fail to show fonts.

Usually, `apache` already has necessary settings, but `nginx` and other
webservers should be tuned. Here is list of mime types for our file extensions:

- `application/vnd.ms-fontobject` - eot
- `application/x-font-woff` - woff
- `application/x-font-ttf` - ttf
- `image/svg+xml` - svg
nickjer commented 8 years ago

You could also use font-awesome. I am unfamiliar with this app, but you'd probably add it similarly to how you added bootstrap.

brianmcmichael commented 8 years ago

This issue is also present with Glyphicons.

icons

nickjer commented 8 years ago

In IE11 is it downloading the fonts file?

brianmcmichael commented 8 years ago

yes

icons2

nickjer commented 8 years ago

Is the DroidSansMono being displayed properly in IE11?

nickjer commented 8 years ago

Also, probably not an issue but I noticed the Content Type for the fonts are text/plain. It only does this for your node app. Can you visit a VNCSim app and see if the glyphicons work as well as the Content Type from within IE11.

nickjer commented 8 years ago

As for the Content Type issue, please check how CloudCMD handles it here:

https://github.com/coderaiser/ponse/blob/master/json/ext.json

As you can see the eot type is missing. If the Content Type is the issue we are seeing, then you may want to put in a pull request to have it added to the ponse.

brianmcmichael commented 8 years ago

Submitted PR at https://github.com/coderaiser/ponse/pull/2

brianmcmichael commented 8 years ago

Merged at https://github.com/coderaiser/ponse/commit/f97c9999b7a10f64faf386f9baa0b251a56561ad

Available in https://github.com/coderaiser/ponse/releases/tag/v1.4.2

Need to test live.

brianmcmichael commented 8 years ago

updated shrinkwrap to permit ponse 1.4.2 at https://github.com/AweSim-OSC/osc-fileexplorer/commit/1939a8fe5cc70d7709a146aefce67842fa19ec9b

works in dev.