Rename? - Githubissues

OSC / ood_appkit

https://osc.github.io/Open-OnDemand/

MIT License

1 stars 2 forks source link

Rename? #2

Closed nickjer closed 8 years ago

nickjer commented 8 years ago

The current name is a little confusing, as it makes me think it is an actual standalone app. Some other options that may or may not clear things up:

ood_appkit
ood_rails
ood_appkit_rails
ondemand_rails
ondemand_appkit
...

nickjer commented 8 years ago

Opinions @basilgohar, @ericfranz, @brianmcmichael?

brianmcmichael commented 8 years ago

ood_rails

ericfranz commented 8 years ago

old name	new name
`osc-machete`	`ood_batch`
`osc-machete-rails`	`ood_batch_rails`
`awesim_rails_logging`	`ood_rails_logging`
`awesim_rails`	`ood_rails` or `ood_app`

originally I had suggested ood_app and ood_rails were separate gems, where ood_app was just "abstractions for where apps and dashboard are, provides deployment cli and rake tasks" versus ood_rails which was "non-namespaced rails engine replacement for awesim_rails" but it seems like these are merging into a single gem. I guess ood_rails.
for reference, comments with the initial proposal for the new gem list: https://github.com/AweSim-OSC/osc-ondemand/issues/26

ericfranz commented 8 years ago

Not sure about these:

old name	new name
`osc-vnc`	`ood_vnc` if it uses `ood_batch` to submit the job
`osc-reservations`	`ood_reservations` or `moab_reservations`

ericfranz commented 8 years ago

FWIW we are also adding the awesim_cli stuff into this ood_app gem...

Maybe ood_appkit_rails is more appropriate. Hate naming stuff...

ericfranz commented 8 years ago

"it makes me think it is an actual standalone app" - honestly, I don't think this is that big of a deal

I like ood_app. :-P

FWIW there is another gem named similarly that has some use (84603 downloads):

http://shopify.github.io/shopify_app/ and https://github.com/Shopify/shopify_app

ericfranz commented 8 years ago

Note: the shopify_app gem is not a standalone app.

ericfranz commented 8 years ago

Ha ha. Okay, ood_app or ood_appkit or ood_appkit_rails or ood_rails I'm fine with them all.

ericfranz commented 8 years ago

Lets go with ood_appkit.

ericfranz commented 8 years ago

OodAppkit.shell.url looks better than OodApp.shell.url (does it?) yeah probably

nickjer commented 8 years ago

Is that your final decision? There are no backsies in the world of coding.