search

OSC / ood_core

Open OnDemand core library
https://osc.github.io/ood_core/
MIT License
10 stars 28 forks source link

check for nohttpd option before using it with vncserver #767

Closed johrstrom closed 2 years ago

johrstrom commented 2 years ago

Fixes #737

johrstrom commented 2 years ago

I've got a ticket with Sci apps to get 3.0 on OSC systems. Would like to test this first, but I'd also like to get it into the next 2.0 release because it's a real pain point for folks.

johrstrom commented 2 years ago

I was able to confirm this works with a module I built myself. The script_wrapper had set -x so here's the output of the 2 cases:

With 2.2.6

+ grep nohttpd
+ timeout 2 vncserver --help
+ HTTPD_OPT=-nohttpd
++ vncserver -log vnc.log -rfbauth vnc.passwd -nohttpd -noxstartup -geometry 1536x864
+ VNC_OUT='

with 3.0

+ vncserver -list
+ grep nohttpd
+ timeout 2 vncserver --help
++ vncserver -log vnc.log -rfbauth vnc.passwd -noxstartup -geometry 1536x864
+ VNC_OUT='