search

OSC / ood_core

Open OnDemand core library
https://osc.github.io/ood_core/
MIT License
10 stars 30 forks source link

find_port: avoid infinite loop #811

Closed utkarshayachit closed 1 year ago

utkarshayachit commented 1 year ago

If all ports in chosen port range were taken, find_port had the tendency to block. This fix updates the code to avoid this and instead attempt to find a port by looping over the port range for a fixed number of retries.

utkarshayachit commented 1 year ago

thanks for the quick merge! Working on a few more cleanups for issues we encountered under AzHOP. Just wanted to introduce myself to the dev team and familiarize myself with the workflow with this small PR :).

johrstrom commented 1 year ago

Well hello there! PRs welcome - that's pretty much the policy. I'm working on a 3.0.2 patch release, so i'll try to get this in there.