OSC / ood_core

Open OnDemand core library
https://osc.github.io/ood_core/
MIT License
9 stars 25 forks source link

Handle Missing Shebang #822

Open Oglopf opened 6 months ago

Oglopf commented 6 months ago

https://github.com/OSC/ood_core/blob/122835c39d3a6115e43e78879b73805db54a660a/lib/ood_core/job/adapters/slurm.rb#L521

While deploying an app I discovered that while you can launch an app with no shebang in the script in a sandbox environment and have things work, if you run this in production, for some reason that shell_path will just fail silently. You will see a file write with the wrong permissions, and that's it.

Let's add some logging to at least signal they need to specify the shell to use for SLURM when this happens in their script.