search

OSC / osc-machete

High level interface to submitting and checking the status of batch jobs (currently OSC specific)
MIT License
1 stars 0 forks source link

Error raised when deleting a job that is completed #107

Open nickjer opened 8 years ago

nickjer commented 8 years ago

When a job finishes it can be in the completed state or gone from the PBS queue completely. Currently, this code:

https://github.com/AweSim-OSC/osc-machete/blob/c0fe844c63a733a5cf6b8333d1a12fc0e895b2b5/lib/osc/machete/torque_helper.rb#L124-L133

only checks if the job id is gone from the PBS queue. We also need to capture the exception raised when the job is completed...

PBS::BadstateError

This exception needs to be confirmed for both the E (Ending) and C (Complete) state that PBS can give.

nickjer commented 8 years ago

Fortunately this does not affect current apps that use osc_machete_rails as a status update is called before every controller action (including delete).