search

OSC / osc-machete

High level interface to submitting and checking the status of batch jobs (currently OSC specific)
MIT License
1 stars 0 forks source link

"live" tests sometimes return false positives #92

Closed ericfranz closed 8 years ago

ericfranz commented 8 years ago

I know these were pulled out into a separate file, but you may still see this behavior. When running the tests on websvcs02, tiny jobs are submitted to Oakley. In certain cases these seem to run immediately:

Finished in 3.027621s, 13.5420 runs/s, 37.9836 assertions/s.

  1) Failure:
TestTorqueHelper#test_qsub_oakley [/nfs/17/efranz/dev/osc-machete/test/test_torque_helper.rb:68]:
Expected: Queued
  Actual: Passed

  2) Failure:
TestTorqueHelper#test_qsub_ruby [/nfs/17/efranz/dev/osc-machete/test/test_torque_helper.rb:95]:
Expected: Queued
  Actual: Running

Maybe we assert to verify its active or completed?

brianmcmichael commented 8 years ago

This was a bug introduced by merge of https://github.com/AweSim-OSC/osc-machete/pull/88 Specifically https://github.com/AweSim-OSC/osc-machete/commit/eac1440ff310242c60f9f6463698eb421871fb6c#diff-a4fe1d4e5a3fba20063ff0614c8b2b40R77

The fork was untested and pulled in prematurely.

https://github.com/AweSim-OSC/osc-machete/pull/91 fixes this issue. Specifically https://github.com/AweSim-OSC/osc-machete/pull/91/files#diff-a4fe1d4e5a3fba20063ff0614c8b2b40R78

brianmcmichael commented 8 years ago

Fixed by https://github.com/AweSim-OSC/osc-machete/pull/91