OSC / osc-reporting

Reporting on OOD jobs ran at OSC
MIT License
2 stars 0 forks source link

Update App Inspector with Action Cable #45

Closed lukew3 closed 2 years ago

lukew3 commented 2 years ago

Enable client to use websocket to request a new version of the histogram, which is replaced in the html. I'd say that I'm slightly leaning towards merging this, but would be okay discarding it as well. I was able to cut down a lot of template code shown in the railsguides, and I think the end solution is pretty clean. It seems to be a little bit faster than the turbo-streams http method as well. Closes #43

┆Issue is synchronized with this Asana task by Unito

gbyrket commented 2 years ago

Websocket fails. Not connecting to host.

Therefore data not updating when slider is adjusted.

image

image

lukew3 commented 2 years ago

@gerald-byrket Hmm, I'm not sure. Maybe it's because you're on ondemand-test.osc.edu and I'm on ondemand.osc.edu? Or maybe you are missing the actioncable gem or your server needs to be restarted. Did you run bin/setup?

gbyrket commented 2 years ago

@gerald-byrket Hmm, I'm not sure. Maybe it's because you're on ondemand-test.osc.edu and I'm on ondemand.osc.edu. Or maybe you are missing the actioncable gem or your server needs to be restarted. Did you run bin/setup?

Ran bin/setup, bundle install, am on your branch, etc, etc, etc.

lukew3 commented 2 years ago

@gerald-byrket Tested it and it works if you're visiting it from ondemand.osc.edu but not if you are on ondemand-test.osc.edu.

Edit: Patched to allow ondemand-test

johrstrom commented 2 years ago

@gbsoftwaresolutions let's hold on merging this. While it's good as it is, I actually don't know if it's the right pattern we want to follow.

The task was to see what it would look like - and this done that. I don't know if it's the pattern we should follow, but I have to admit it's less code than I thought it'd be.

At any rate - this is OK to just hold here for a bit while we all start to figure out what idiomatic Turbo looks like.