OSC / phylogatr-web

The web app for the Phylogatr Project - https://phylogatr.org/
https://phylogatr.org/
MIT License
0 stars 0 forks source link

add a gitlab ci to build and push images #3

Closed johrstrom closed 2 years ago

johrstrom commented 2 years ago

add a gitlab ci to build and push images

johrstrom commented 2 years ago

@treydock is this all we need? Gitlab will auto login, all we have to do is build and push I guess right?

treydock commented 2 years ago

Correct, the gitlab-runner user has the docker-registry.osc.edu information stored for that user so all projects we authorize to use our runner can in theory push images to our registry.

The only change I'd make is to setup 2 stages. One stage to build on tags and pull requests and another stage to push the image but only on tags. That way you are stressing the image building on pull requests. If that's not a concern then can just use what you have.

I will have to update the runner configs to force shell runner so you run local docker commands and not doing like docker-in-docker which is more complicated.

johrstrom commented 2 years ago

Thanks. I think as you've indicated, we'll use github to build and push to our registry instead of having to maintain the fork.