OSC / phylogatr-web

The web app for the Phylogatr Project - https://phylogatr.org/
https://phylogatr.org/
MIT License
0 stars 0 forks source link

Gh action tag image #4

Closed johrstrom closed 2 years ago

johrstrom commented 2 years ago

Gh action tag image and push it to the OSC container registry.

treydock commented 2 years ago

So there are actions to handle some of this and they are published by Docker developers so seems legit:

      - name: Login to DockerHub
        uses: docker/login-action@v1 
        with:
          username: ${{ secrets.DOCKER_HUB_USERNAME }}
          password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}

There is also one to build and push:

      - name: Build and push
        id: docker_build
        uses: docker/build-push-action@v2
        with:
          context: ./
          file: ./Dockerfile
          push: true
          tags: ohiosupercomputer/job-pod-reaper:${{ steps.version.outputs.version }}

Can do multiple tags if you want

johrstrom commented 2 years ago

Looks like we need Gitlab to connect to internal OSC repos

https://github.com/OSC/phylogatr-web/blob/a0df1de94db3350fe91f812af1c97630fc4f3075/Dockerfile#L48-L49

treydock commented 2 years ago

@johrstrom The only repo OSC would need is SLURM repo and rather than use SLURM repo could just build from source. If SLURM is executed in the container then don't need Lua plugin, that's only needed for how I build RPMs for OSC. I'd recommend to just build SLURM in the container from source using version we use at OSC which is 20.11 release series.

treydock commented 2 years ago

Or you can install from EPEL, SLURM is in EPEL now but they do major version updates so sometime in future they may have 21.08 in EPEL but right now it's still 20.11.8 which is compatible with our systems.

johrstrom commented 2 years ago

Thanks. I already got the image to build in gitlab, so I guess we'll just keep it there.