search

OSC / puppet-module-openondemand

0 stars 16 forks source link

\n not working in 3.1 #145

Closed johrstrom closed 12 months ago

johrstrom commented 1 year ago

It may be due to the ruby upgrade - but things like this will not work in the next release.

https://github.com/OSC/ood-documentation/blob/5edc35056d03ddaf4bc1f5b126c94784d983170e/source/installation/cluster-config-schema.rst?plain=1#L51-L54

We need to update documentation to use multiline strings like this (and likely add a breaking change to the 3.1 release notes).

    batch_connect:
        basic:
          script_wrapper: |
            module restore
            %s
        vnc:
          script_wrapper: |
            module restore
            module load ondemand-vnc
            %s
johrstrom commented 12 months ago

This was not an actual issue on the OnDemand side - it was part of the puppet templating update that occurred, so i'm going to migrate that over there.

johrstrom commented 12 months ago

This is just a documentation thing that I'll submit a patch for.

For reference - this was fixed on OSC systems in merge request 601 (in our internal puppet config repo).