Closed mosespace closed 1 year ago
I had to delete the whole branch and redo stuff. unfortunately i had many branches created that were disturbing me to figure out!!!
@HassanBahati am calling in for a review. Thank you
Please check if the PR fulfills these requirements
[ ] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added / updated (for bug fixes / features)
[x] I have included in this PR's description the statement
closes #xx
orfixes #xx
where #xx is the number of the issue being addressed.What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This pr adds both new features, updates and as well as fixes bugs!
What is the current behavior? (You can also link to an open issue here) At he current state: there was a bug on the dark mode and light mode which was fixed!
What is the new behavior (if this is a feature change)? Now the program is able to run in all the three light stages without making any changes to the styling!
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No breaking change is required on this pull request!
Other information: This pr closes #130 This pr closes #105
Thank you for the pull request request guide/template!! its dope :+1: :smile:
@mosespace thank you for the contribution!
please in the description of this pr add This pr closes #xx
where xx is the issue number of the issues that this pr resolves.
This will close those issues automatically when this pr is merged
@mosespace thank you for the contribution!
please in the description of this pr add
This pr closes #xx
where xx is the issue number of the issues that this pr resolves.This will close those issues automatically when this pr is merged
Thank you for the appreciation. Am looking forward to resolving other issue
@mosespace thank you for the contribution! please in the description of this pr add
This pr closes #xx
where xx is the issue number of the issues that this pr resolves. This will close those issues automatically when this pr is mergedThank you for the appreciation. Am looking forward to resolving other issue
yah sure, let me add more issues shortly....
@mosespace thank you for the contribution!
please in the description of this pr add
This pr closes #xx
where xx is the issue number of the issues that this pr resolves.This will close those issues automatically when this pr is merged
@mosespace i think for the second issue you have tagged i think you meant #105 rather than #103
@ht-thomas this is ready for merging
@mosespace thank you for the contribution! please in the description of this pr add
This pr closes #xx
where xx is the issue number of the issues that this pr resolves. This will close those issues automatically when this pr is mergedThank you for the appreciation. Am looking forward to resolving other issue
yah sure, let me add more issues shortly....
@mosespace thank you for the contribution! please in the description of this pr add
This pr closes #xx
where xx is the issue number of the issues that this pr resolves. This will close those issues automatically when this pr is merged@mosespace i think for the second issue you have tagged i think you meant #105 rather than #103
@HassanBahati thank you, i have resolved it
@ht-thomas this is ready for merging
@ht-thomas let's move on
Please check if the PR fulfills these requirements
[ ] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added / updated (for bug fixes / features)
[x] I have included in this PR's description the statement
closes #xx
orfixes #xx
where #xx is the number of the issue being addressed.What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This pr adds both new features, updates and as well as fixes bugs!
What is the current behavior? (You can also link to an open issue here) At he current state: there was a bug on the dark mode and light mode which was fixed!
What is the new behavior (if this is a feature change)? Now the program is able to run in all the three light stages without making any changes to the styling!
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No breaking change is required on this pull request!
Other information This pr closes #130 This pr closes #105