OSCA-source / OSCA.basic

Basics of the OSCA book
10 stars 11 forks source link

Broken between-book links in Chapter 5 Clustering #10

Closed PeteHaitch closed 1 year ago

PeteHaitch commented 1 year ago

These links aren't resolving correctly in either 3.16 or 3.17 branches of the rendered book:

https://github.com/OSCA-source/OSCA.basic/blob/8d243a21692c51f0cabd9948748888dabf2ef3ac/inst/book/clustering.Rmd#L129 https://github.com/OSCA-source/OSCA.basic/blob/8d243a21692c51f0cabd9948748888dabf2ef3ac/inst/book/clustering.Rmd#L198 https://github.com/OSCA-source/OSCA.basic/blob/8d243a21692c51f0cabd9948748888dabf2ef3ac/inst/book/clustering.Rmd#L446

Instead appearing like the below screenshot image

PeteHaitch commented 1 year ago

549aab3 only partially fixed the issue. Problem is that link("graph-diagnostics", "OSCA.advanced") ~and link("comparing-different-clusterings", "OSCA.advanced") aren't~ isn't a valid reference in OSCA.advanced whereas link("comparing-different-clusterings", "OSCA.advanced") (linking to https://github.com/OSCA-source/OSCA.advanced/blob/ac133eddae37b199c55256d43182cf8f457fa829/inst/book/more-clustering.Rmd#L209) and link("silhouette-width", "OSCA.advanced") is (linking to https://github.com/OSCA-source/OSCA.advanced/blob/ac133eddae37b199c55256d43182cf8f457fa829/inst/book/more-clustering.Rmd#L48). Will need to identify where link("graph-diagnostics", "OSCA.advanced") is supposed to be linking to and, if necessary, create the appropriate tag.

PeteHaitch commented 1 year ago

@ltla Do you know/remember which section rebook::link("graph-diagnostics", "OSCA.advanced") is supposed to resolve to?

LTLA commented 1 year ago

Think it might be https://github.com/OSCA-source/OSCA.advanced/blob/master/inst/book/more-clustering.Rmd#L162.

PeteHaitch commented 1 year ago

Thanks!