Open clange opened 7 years ago
@s6fikass would you please upload the CSS of ACM and Springer that I showed to you and the one we tested together in FW. I did not see them in https://github.com/OSCOSS/fiduswriter/tree/FW_styleManager
@s6fikass is the repository https://github.com/fiduswriter/fiduswriter/tree/pdftex for this issue?
@sadeghiafshin that branch I created to help @s6fikass to merge his changes with upstream FW. There were still some things that needed to be done two weeks ago to get the final patch merged with upstream. I haven't heard from it since.
@s6fikass still I do not see your new commits on the github.
@sadeghiafshin https://github.com/fiduswriter/fiduswriter/tree/pdftex has been updated, merging both latest commits from @s6fikass and latest changes from develop branch. Haven't tested.
@s6fikass It's marking all your commits with a red cross because you haven't clicked on the button to agree with the CLA. Could you please do that? Otherwise the tests won't run.
@s6fikass Also, there are several issues with the python/javascript checkers. could you run:
npm run check_py
and
npm run check_js
and then fix the errors those two commands give you?
Hey, @s6fikass and @sadeghiafshin I tried those styles and there were a number of CSS selectors that needed to be changed, so I created a new repo just for document styles: https://github.com/fiduswriter/styles . Please make any additions/changes there directly. There is still an issiue with these files mentioning fonts that aren't installed by default in Fidus Writer. I don't know if they are available under free licenses and if we can bundle them. Any idea, Firas?
@johanneswilm @s6fikass I see that this work tried to do a similar work but only in the publish level. Here is the result https://dokie.li/acm-sigproc-sp#ref-1 and the source CSS is: https://dokie.li/media/css/acm.css @s6fikass can you make a short comparison of this template and our last status of the work in this issue?
hey, yes, @s6fikass please do all further work on this in or as forks of https://github.com/fiduswriter/styles so that the last work I put into this isn't lost.
@sadeghiafshin let me initially assign this to you, but please feel free to reassign.