Open Asbjoern opened 8 years ago
Thank you for the commit. I need to evaluate the impact to the BT 3.x and 4.x boards which first used this logic.
On Tue, Feb 23, 2016 at 2:31 AM Asbjørn Mejnertsen notifications@github.com wrote:
I had to make the following code changes to get Brewtroller to work on my board (Based on DX2).
74xx595 uses inverse logic on enable pin.
muxDataPin.set(bool) does not work (Arduino 1.6.7 problem?) Logic expanded to use .set() and .clear() instead.
Arduino 1.6.7 does not like static const declaration.
You can view, comment on, or merge this pull request online at:
https://github.com/OSCSYS/brewtroller/pull/32 Commit Summary
- 74xx595 logic and Arduino 1.6.7 compiler fix
File Changes
- M LOCAL_PID_AutoTune_v0.h https://github.com/OSCSYS/brewtroller/pull/32/files#diff-0 (4)
- M Outputs.cpp https://github.com/OSCSYS/brewtroller/pull/32/files#diff-1 (11)
Patch Links:
- https://github.com/OSCSYS/brewtroller/pull/32.patch
- https://github.com/OSCSYS/brewtroller/pull/32.diff
— Reply to this email directly or view it on GitHub https://github.com/OSCSYS/brewtroller/pull/32.
I had to make the following code changes to get Brewtroller to work on my board (Based on DX2).
74xx595 uses inverted logic on enable pin.
muxDataPin.set(bool) does not work (Arduino 1.6.7 problem?) Logic expanded to use .set() and .clear() instead.
Arduino 1.6.7 does not like static const declaration.