search

OSDG-IIITH / OLD_courier_portal

Courier Portal at IIIT-H : Outdated as of now.
2 stars 4 forks source link

Making a separate Config File for SQL #1

Open gauravmittal1995 opened 9 years ago

gauravmittal1995 commented 9 years ago

Many Files (admin.php, automate.php ,etc) have db config inside them. So if we want to change some configuration (say password or db name or something), we will have to open all files and do them one by one. Its better to make a seperate config file and include this in all the others.

Eg: https://github.com/OSDG-IIITH/courier/blob/master/admin.php#L3-8 https://github.com/OSDG-IIITH/courier/blob/master/automate.php#L3-9 https://github.com/OSDG-IIITH/courier/blob/master/delete.php#L2-8

and many more

gauravmittal1995 commented 9 years ago

Should I do this?

akshay1994 commented 9 years ago

Yes! This is one of the things in the initial-tasks list. (I had to manually comment out the password in all of the files)

akshay1994 commented 9 years ago

I'll wait for this, before hosting the development branch.