search

OSDG-IIITH / www

This repository is the landing page for osdg.iiit.ac.in.
Other
4 stars 16 forks source link

Major coding style and file structure fixes #6

Closed nisargjhaveri closed 9 years ago

nisargjhaveri commented 9 years ago

Also give a link to GitHub contributors

amoghbl1 commented 9 years ago

There was a PR before this that I merged... Think you need to update it!

ffledgling commented 9 years ago

@mrinaldhar Since you wrote the original, you should probably the one to review this PR.

@nisargjhaveri I think this needs a rebase, it's based off of a version when css/* didn't exist. You might also want to fix #12 before you proceed with this.

mrinaldhar commented 9 years ago

Since we decided to paginate the website now, there is no 'main' js and css. I usually follow this convention while naming js and css files:

  1. Files that are specific to a certain HTML file take the same name as the HTML file. (index.css, stories.css)
  2. File that is common to all takes the name standard.css/standard.js

Also, since we don't have a near-release version yet, and I'm constantly going into code to make big changes, I'd prefer it if we hold off coding style fixes. We also have an issue created for that, lets see where that discussion goes and then we can modify the code for the existing files.

nisargjhaveri commented 9 years ago

This PR coincided with similar PR by @mrinaldhar. I think a rebase won't work anymore.

The best is to close this now and redo it later. Closing now.

ffledgling commented 9 years ago

wfm!