OSDLabs / Encore

Intranet Music Player
http://10.4.9.32:2000/
MIT License
18 stars 13 forks source link

Settings can be accessed by any client player #8

Closed 0xRampey closed 7 years ago

0xRampey commented 7 years ago

Settings can be used to change the current music directory of the server from any client player. This feature should be removed and relocated into a separate function for use only on the server.

mukkachaitanya commented 7 years ago

Commenting all the un-required functionality on the client side player.

0xRampey commented 7 years ago

@mukkachaitanya By un-required do you mean unnecessary utilities? Because the dangerous commented functions can still be used for malicious purposes.

SebastinSanty commented 7 years ago

@prampey I guess this can be a sub of #9 and closed

kaivalyar commented 7 years ago

might still want to go through all commented code before releasing to check security ...

mukkachaitanya commented 7 years ago

In fact there are few other things that modify the details in the database which need to be removed from the code.