search

OSDeploy / OSD

OSD Shared Functions
MIT License
149 stars 61 forks source link

Getting: PS>TerminatingError(): "System error." in setupcomplete.ps1 #115

Closed StevenVBeek closed 7 months ago

StevenVBeek commented 7 months ago

HP EliteBook 840 14 inch G9 Notebook PC.json HP Image Assistant.log HPIACustomLog.log HP.JSON SetupComplete.log Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior: Enable: HPIAFirmware = $true

Expected behavior I think when there are no recommendation the scripts just need to be finished without Exit 0 .

Screenshots see logs.

Desktop (please complete the following information):

Additional context In the Invoke-HPIA function, if there's an exit code of 257, it will trigger an exit with code 0. This action halts the execution of the entire setupcomplete.ps1 script, preventing any settings from running after the firmware is invoked.

@gwblok can we remove the Exit 0 if that is they issue (also for exitcode 256)? Line 247 in Invoke-HPIA.ps1

gwblok commented 7 months ago

Yes, thank you, I missed those earlier. Done. Code is updated on GitHub, will be part of next OSD Module Release