search

OSDeploy / OSD

OSD Shared Functions
MIT License
130 stars 54 forks source link

Unable to install fr-CA images #117

Open coveowlebel opened 4 months ago

coveowlebel commented 4 months ago

Describe the bug When trying to install Windows 11 fr-CA Pro Retail image (Seems to not care about the specific version), it fails due to a missmatch of the OS Index. The scripts assumes 9, but in the fr-CA image, it is 6.

To Reproduce Steps to reproduce the behavior: Run the following command: Start-OSDCloud -OSName 'Windows 11 21H2 x64' -OSLanguage fr-ca -OSEdition Pro -OSActivation Retail -ZTI -Firmware -Restart

OSDCloud will run but will fail to install the OS.

Expected behavior Windows is installed in French.

Additional context Log file of the run: 2024-03-01-121838-Deploy-OSDCloud.log

gwblok commented 4 months ago

Thanks for letting me know. I don't do any testing other than en-us. I confirmed that the fr-ca does have a different index list than I expected. I'll have to think for a bit, and see how I can try to resolve this. Guessing it will mean a rather large change in logic, so it might be awhile before this is fixed.

Confirmed: image

gwblok commented 4 months ago

I've got an idea, perhaps setting the variable OSImageIndex to 6 before you trigger OSDCloud would work. you can take a look at a sample OSDCloud trigger script I'll test next week, which pre-sets several OSDCloud variables before launching OSDCloud: https://github.com/gwblok/garytown/blob/master/Dev/CloudScripts/fr-ca.ps1

I will still look into a better solution, but this might be a workable workaround until I get time.

gwblok commented 4 months ago

Work around tested and worked: image

image

So for now, you should be in business. I'll see if I can get a proper matching working for other languages, but it might take a long while.

coveowlebel commented 4 months ago

Awesome, thanks for the quick turnaround! Ill take a look at implementing your script.

gwblok commented 4 months ago

The script is an example of how you can "wrap" OSDCloud in your own processes. Feel free to take what you want.
In my process, since do image a lot of HP Devices, I first call a script to set BIOS Settings. I also set several other variables for use in OSDCloud.

gwblok commented 4 months ago

@coveowlebel, how has your testing gone? Are you back in business?

coveowlebel commented 4 months ago

Yep all good! Took your script and modified it to just having what we need.

gwblok commented 3 months ago

I've updated Start-OSDCloudGUIDev to dynamically pull Editions and Indexes from a "database". This should resolve the issue.
It will be released in the next module update, at which point I'll do more testing.

This is a HUGE change to how OSDCloud works, so it might be awhile before it is promoted into the main Start-OSDCloudGUI (Production).

gwblok commented 3 months ago

@coveowlebel, can you test Start-OSDCloudGUIDev in the latest module (24.3.20.1) I've made some changes to the that process, so it dynamically checks the ESD for which indexes are available.

gwblok commented 3 months ago

This change will be in the DEV GUI for awhile, as it has some larger ramification when promoting to Production as it has potential to break people's automation.

Please @coveowlebel test in DEV (Start-OSDCloudGUIDEV) and see how it goes for you.

gwblok commented 1 month ago

bump @coveowlebel, have you done any testing?