search

OSDeploy / OSD

OSD Shared Functions
MIT License
144 stars 59 forks source link

Bugfixed Save-WebFile and Update-MyWindowsImage #44

Closed andre-sicking closed 1 year ago

andre-sicking commented 1 year ago

Hi David,

I wanted to test the integration of OSD in my build processes today instead of using OSDBuilder which we talked about on Twitter this week. While testing I found some issues when not having curl.exe at hand and updating WS2016 OS.

Save-WebFile: I renamed $WebClient to $WebClientTemp when it comes to the download itself as it interferes with the Param $WebClient which is of another type (System.Management.Automation.SwitchParameter instead of System.Net.WebClient) which can't be changed at this stage. As a consequence the download fails.

Update-MyWindows Image: I never got any updates reported, even on very old install.wim files. I guess that the fact that Get-RegCurrentVersion running on WS2016 does not return ReleaseId is the issue here. Did you accidently swapped DisplayVersion and ReleaseId? Swapping these fields in the If-statement fixes the issue with 2016.

Please let me know if I can do better providing Pull-Requests. As always you can also reach out to me via Twitter (@andre_sicking).

andre-sicking commented 1 year ago

Discovered a bug in this "fix".