OSDeploy / OSD

OSD Shared Functions
MIT License
150 stars 61 forks source link

Get-FeatureUpdate broken for me since 23.4.25.1 Release #64

Closed mmeierm closed 1 year ago

mmeierm commented 1 year ago

Describe the bug A clear and concise description of what the bug is. Since the 23.4.25.1 Release, the Get-FeatureUpdate seems to be broken for me

To Reproduce Steps to reproduce the behavior: Get-FeatureUpdate -OSName 'Windows 11 22H2 x64' gives out Windows 10 22H2 x86

Expected behavior A clear and concise description of what you expected to happen. It should give out 'Windows 11 22H2 x64'

Screenshots If applicable, add screenshots to help explain your problem. Not working: image with an older version: image

Thanks a lot

OSDeploy commented 1 year ago

Thanks for catching this, it's been corrected

image
mmeierm commented 1 year ago

Thanks a lot, now it's returning x64, but still Windows 10 instead of Windows 11:

image image

It seems to me like it ignores the OSName Input?

OSDeploy commented 1 year ago

I should have had more coffee today. I pushed 23.4.26.2 to resolve this issue

mmeierm commented 1 year ago

Thank you so much, now it's working just fine.

OSDeploy commented 1 year ago

If you don't mind me asking, what do you use this function for? This was used in OSDCloud, but I've been migrating towards this function instead Get-OSDCloudOperatingSystems image

mmeierm commented 1 year ago

I'm using a custom launcher UI, that enables me to allow our users to upload the devices to Autopilot like i described here: https://mikemdm.de/2023/01/29/can-you-create-a-autopilot-hash-from-winpe-yes/ https://mikemdm.de/2023/02/12/automate-autopilot-uploads-with-azure-automation-runbooks/ This Custom UI will automatically detect if Windows 10 or 11 should be installed, based on HW Infos like used CPU, as we only allow Win 10 for older devices, but we still wanted the option to select Language and used DriverPack image The UI will internally then create the StartOSDCloudGUI Variable with the values and hand over to Start-OSDCloud, which still uses this function... image

OSDeploy commented 1 year ago

That looks awesome. We need to chat about some of the new changes that may be helpful to you!