OSDeploy / OSD

OSD Shared Functions
MIT License
132 stars 54 forks source link

Issue or incorrect list for Microsoft Drivers to USB #82

Open Abe-Telo opened 8 months ago

Abe-Telo commented 8 months ago

Describe the bug A clear and concise description of what the bug is. Issue is that when using update-osdcloudusb -Drivers Microsoft, Sometimes it says the file already exists and then skip it, When you run the command again, it shows that its already downloaded when you missing some drivers.

Based on the log it looks like it uses the same name for 4G LTE north America, Twice, and it does not look for Verizon LTE.
This is repeated multiple time during downloading surface Drivers and a clean USB.

Knows missing Drivers Microsoft Surface 3 LTE Verizon Win 10 1903

And Based on logs, the repeated drivers.
This info is not to claim missing drivers but to bring awareness of the possibility.

The following can be accepted, but providing the info so we are aware. Surface Book 2, On the catalog, it shows. 1832, and 1793 are to be downloaded however, SurfaceBook2_Win10_19044_23.092.25730.0 is downloaded. ( this can be a good thing but is misrepresented..) Repeated instances with the following.
SurfaceBook3_Win10_19044_23.092.28627.0

Is there a difference between these image

The only file that is downloaded is SurfaceGo2_Win10_19044_23.093.19290_0.msi

Surface Pro 6 Commercial and Consumer (Same File Name) is there a difference here? SurfacePro7+_Win10_19044_23.091.9841.0.msi SurfacePro8_Win10_19044_23.093.30318.0.msi SurfaceBook2_Win10_19044_23.092.25730.0.msi SurfaceBook3_Win10_19044_23.092.28627.0.msi

SurfaceGo2_Win10_19044_23.093.19290_0.msi (it shows 3X Dublicate) SurfaceGo3_Win10_19044_23.093.36099.0.msi (it shows 3X Dublicate)

SurfaceLaptop5_Win10_19044_23.094.39987.0.msi (it trys to download 4 X)

SurfaceLaptop4_Intel_Win10_19044_23.091.11395.0.msi SurfaceLaptop4_AMD_Win10_19044_23.092.16939.0.msi

I am aware that it must be models sharing the same drivers. And probably, this means nothing. However, since i found an issue here is the report.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...' Run update-osdcloudusb -Drivers Microsoft
  2. Click on '....' Select all (No matter, In my case All Surface 3)
  3. Scroll down to '....' Click ok
  4. See error VERBOSE: SourceUrl: https://download.microsoft.com/download/7/5/7/757B0C6E-0C22-400B-90EA-D8AFBD64CC16/Surface3_4GLTE-NorthAmericaUnlocked_ Win10_18362_1902003_0.msi VERBOSE: DestinationName: Surface3_4GLTE-NorthAmericaUnlocked_Win10_18362_1902003_0.msi VERBOSE: DestinationDirectory: D:\OSDCloud\DriverPacks\Microsoft VERBOSE: Overwrite: False VERBOSE: WebClient: False VERBOSE: Directory already exists at D:\OSDCloud\DriverPacks\Microsoft VERBOSE: Destination Directory is writable at D:\OSDCloud\DriverPacks\Microsoft VERBOSE: DestinationName: Surface3_4GLTE-NorthAmericaUnlocked_Win10_18362_1902003_0.msi VERBOSE: DestinationFullName already exists VERBOSE: SourceUrl: https://download.microsoft.com/download/4/C/7/4C7DA85D-03DE-4B89-B8E0-386437331C46/SurfacePro_Win10_19044_23.092.28606. 0.msi

Screenshots image image

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

https://github.com/OSDeploy/OSD/blob/d2f131a95956492a2afa028d7198e62bf4c7eb66/Catalogs/MicrosoftDriverPackCatalogLegacy.json#L5

https://www.microsoft.com/en-us/download/details.aspx?id=49920

Also, adding a feature request Where we have the option to download the drivers locally, instead of always redownloading per USB,