OSDeploy / OSDBuilder

PowerShell Module
http://osdbuilder.com
MIT License
193 stars 55 forks source link

Downloading OneDriveSetup.exe with the WebClient doesn't work correctly #71

Open NKK80 opened 2 years ago

NKK80 commented 2 years ago

The variables on row 280 of Save-OSDBuilderDownload.ps1 are empty when PowerShell tries to download OneDriveSetup.exe with the WebClient.

When those variables are changed to the same variables used by WebRequest (row 283) and Curl (row 288 & 293), "$DownloadUrl" & "$DownloadPath\$DownloadFile", the Download does work correctly.

WebClientError

OSDeploy commented 2 years ago

Can you test this using the latest OSD Module 22.1.11.2 image

NKK80 commented 2 years ago

image

Some additional information is that we are behind a proxy, because of this "Save-OSDBuilderDownload.ps1" will try to use the WebClient to download the OneDrive setup. And like I said in my original post the variables for the WebClient download of the OneDrive setup are empty. I can change "Save-OSDBuilderDownload.ps1" myself to make the download work, but I would prefer it to work without that.

NKK80 commented 2 years ago

Just tried to Download OneDriveEnterprise again, and the script still uses the same empty variables. image

OSDeploy commented 2 years ago

I’m looking into this, standby

On Thu, Mar 10, 2022 at 10:09 PM NKK80 @.***> wrote:

Just tried to Download OneDriveEnterprise again, and the script still uses the same empty variables. [image: image] https://user-images.githubusercontent.com/97504932/157800119-ed88e55a-4a46-4809-b625-ce5011bd21c1.png

— Reply to this email directly, view it on GitHub https://github.com/OSDeploy/OSDBuilder/issues/71#issuecomment-1064752412, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADC6QFURRESODEKWMY7KASLU7LBNVANCNFSM5LV7GRKQ . You are receiving this because you were assigned.Message ID: @.***>

jespinoza84 commented 2 years ago

Seeing this as well when running from Server 2016 v1607. Works fine when I run the same from my Windows 10 20H2 Workstation.