search

OSDeploy / OSDBuilder

PowerShell Module
http://osdbuilder.com
MIT License
193 stars 55 forks source link

New-OSBuildMultiLang.ps1 - Fix UpdateOS for Win11 #94

Open suazione opened 1 year ago

suazione commented 1 year ago

CU was never applied for Win11 because OSUpdate variable was always set to Windows 10. due to a small typo/bug where $WindowsImageMediaName was set to non-existing property of MediaName instead of ImageName (..\info\xml\Get-WindowsImage.xml)

Simsi1986 commented 1 year ago

Thx a lot, that you implemented some fix for that issue - I also did some investigation and could only recognize the root cause (wrong/different variables used), why your fix in the AllFunctions.ps1 was not used for New-OSBuildMultiLang.ps1. Unfortunately, I'm not so familar with Powershell to adjust existing scripts with that huge number of nesting and dependencies to do some adjustments like you did.

Therefore it's impressive that it's just that low code change, even if I can imagine that there was maybe some more effort to fire out that i's quite simple solution.

Just have tested it by changing local stored "New-OSBuildMultiLang.ps1" and can confirm it's working and approved the commit in Github - hopefully it will be included in OSDBuilder soon.

suazione commented 1 year ago

Great, thanks for testing and verifying. :)

Simsi1986 commented 1 year ago

@OSDeploy I know, you are busy and loaded with lots of other things, which is why I almost don't dare to ask. Could you kindly accept this pull request?

OSDeploy commented 1 year ago

I'd love to but this weekend my Internet went out on Friday due to storms ... I don't have an ETA when I'll be back online, and when I do, I need to catch up on some work that's due Monday. Give me a few days to sort things out

On Sat, Jun 24, 2023 at 7:11 PM Simsi1986 @.***> wrote:

@OSDeploy https://github.com/OSDeploy I know, you are busy and loaded with lots of other things, which is why I almost don't dare to ask. Could you kindly accept this pull request?

— Reply to this email directly, view it on GitHub https://github.com/OSDeploy/OSDBuilder/pull/94#issuecomment-1605785663, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADC6QFTSZQLC4AKD6EIERQ3XM562XANCNFSM6AAAAAAZBRGBN4 . You are receiving this because you were mentioned.Message ID: @.***>

Simsi1986 commented 1 year ago

I cross fingers, that your connection will be recovered soon. Take the time you need, I just wanted to make you aware of this pull request.

xe0n11 commented 9 months ago

+1 for having this accepted into the next build. 👍

FLeven commented 8 months ago

Could this also apply to 2022 Server ?

Simsi1986 commented 7 months ago

@OSDeploy I know you're busy, but could you please just merge some of the highly requested pull requests which have been successfully tested like this one?

@FLeven I wouldnt expect that MultiLanguage will be available for Windows Server as even update for client OS is higly wanted since months. On the other hand I in general recommend to not use any other language than English for server OS for certain reasons - most are historical, but it's the IT language even if I know from our multi-country org that this is not common for all. We recently started to stick togeter cross-country wise with the decision that base language for all images will be English and the expectation is that everyone willing to work in IT is willing to at least be able to have some basic English skills in written form as most documentation in the web is in English as well (and I agree, even if it's not my mother tongue). I respect your request, it might be based on requirements which you haven't decided in your company.