search

OSGeo / Cat-Interop

Better interoperability between open source metadata servers and clients.
http://wiki.osgeo.org/wiki/Cat-Interop
MIT License
23 stars 21 forks source link

Added cloud IDs to LinkPropertyLookupTable #32

Closed amilan17 closed 6 years ago

amilan17 commented 6 years ago

AWS:S3, Google:BigQuery and Google:GCS

rsignell-usgs commented 6 years ago

@amilan17 this is minor, but still....

Why "AWS:", but "Google:". Seems like either "AWS:/GCE:" or "Amazon:/Google:" would be more parallel form. I would vote for "AWS:/GCE:"

tomkralidis commented 6 years ago

I'm not too familiar with the details, but are the AWS: and Google: link types actioned in the same way? If yes, I would merge into a single entry representing the common thing they implement? Else keep distinct.

amilan17 commented 6 years ago

Hi Rich, Thanks for the suggestion. I think that's a reasonable request. My colleague suggests using GCP instead of GCE...

"I agree the namespace for Google could be improved/more specific. However,

it looks like GCP for Google Cloud Platform might be an appropriate namespace to use here, because BigQuery, Google Cloud Storage (GCS) and Google Compute Engine (GCE) are listed as GCP products https://cloud.google.com/products/. The two protocol names would become, GCP:BigQuery GCP:GCS"

If this still makes sense, I can change the pull request.

Anna ~~Metadata Adds Meaning~~ Anna.Milan@noaa.gov, 303-497-5099 NOAA National Centers for Environmental Information ~~~~~~~~

On Mon, May 21, 2018 at 12:01 PM, Rich Signell notifications@github.com wrote:

@amilan17 https://github.com/amilan17 this is minor, but why "AWS", but "Google". Seems like either "AWS/GCE" or "Google/Amazon" would be more parallel form.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OSGeo/Cat-Interop/pull/32#issuecomment-390733581, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7e4qDxbiyjAF_d6zejlpZ5I37gE4Ltks5t0wDjgaJpZM4TQZL4 .

tomkralidis commented 6 years ago

OK so I misread @rsignell-usgs. Note there is nothing wrong with using multiple qualifiers, e.g.

dneufeldcu commented 6 years ago

@tomkralidis ok, this is already to go, let's merge!

rsignell-usgs commented 6 years ago

@tomkralidis , looks good to me also.

amilan17 commented 6 years ago

Thank you!

Anna ~~Metadata Adds Meaning~~ Anna.Milan@noaa.gov, 303-497-5099 NOAA National Centers for Environmental Information ~~~~~~~~

On Tue, Jun 5, 2018 at 3:52 PM, Tom Kralidis notifications@github.com wrote:

Merged #32 https://github.com/OSGeo/Cat-Interop/pull/32.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OSGeo/Cat-Interop/pull/32#event-1664812284, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7e4sPeq871tOfDH8UDqcBGUY3QtJ4Gks5t5v2EgaJpZM4TQZL4 .