search

OSGeo / PROJ-JNI

Java Native Interface for PROJ
https://osgeo.github.io/PROJ-JNI/
MIT License
23 stars 15 forks source link

Update package, URL, and copyright from Kortforsyningen to OSGeo #48

Closed willcohen closed 3 years ago

desruisseaux commented 3 years ago

I did not tested yet, but at a first look it seems all right.

kbevers commented 3 years ago

The code parts looks okay but you can't just change the copyright retroactively. Not sure if OSGeo is the correct copyright holder from now on either. I'll have to look into that and get back with better feedback.

desruisseaux commented 3 years ago

Ah yes indeed, I was too focused on the code. Transfering the copyright may require Kortforsyningen to produce some legal paper, but doing such transfer is probably not needed. I think it is also fine to have code hosted at OSGeo with different copyright holders. It is the case of PROJ code itself if I remember right. It is also the standard practice at Apache Software Foundation for example.

kbevers commented 3 years ago

There' are two problems here. The first is that "Kortforsyningen" is listed as a copyright holder in some places - that should be "Agency for Data Supply and Efficiency" (Kortforsyningen is a brandname within the agency and can't as such be a copyright holder). This should be corrected. The second problem is that the copyright holder is overwritten here. That should be dealt with by adding new copyright lines for the years after 2019. So we have something like

Copyright (c) Agency for Data Supply and Efficiency, 2019-2021 Copyright (c) Open Source Geospatial Foundation, 2021-20xx

Still not sure if OSGeo is the proper copyright holder but at least it's better than nothing. Individual developers might also want to put their name in I guess.

willcohen commented 3 years ago

Apologies. Will revise!

kbevers commented 3 years ago

Apologies

No worries, it's not easy to get these things right. After having done the copyright and license review of PROJ my spidey-sense is always tingling when it comes to meddling with the legalese

willcohen commented 3 years ago

Apologies for losing track of this. Updated the statements to reflect a 2019-2021 and 2021 copyright, and force-pushed so that there's no incorrect labelling on an intermediate commit.

desruisseaux commented 3 years ago

No problem, thanks for the update. Just tried and I confirm that it builds and passes the tests at least on my machine (not yet upgraded to PROJ 8). Opened a few random files and it seems all right. On a very minor note, some files have a trailing space on the following lines:

Copyright © 2019-2021 Agency for Data Supply and Efficiency
willcohen commented 3 years ago

Good catch -- find/replace issue!