OSGeo / PROJ-data

Repository for proj datum grids (for use by PROJ 7 or later)
Other
72 stars 33 forks source link

New revisions of chartdatum norway v2023b #112

Closed himsve closed 10 months ago

himsve commented 10 months ago

New separation model model between ETRS89 ell. height and CD_NORWAY

The GeoTiff no_kv_CD_above_Ell_ETRS89_v2023b.tif is the lastest version of the vertical offset grid (separation model) from ETRS89 ell. heights (EPSG:4937) to CD_NORWAY depths (EPSG:9672).

jjimenezshaw commented 10 months ago

Are you going to delete it, or create a new one?

Actually I see it was already superseded by https://epsg.org/transformation_10130/ETRS89-to-CD-Norway-depth-2.html, but not deleted.

rouault commented 10 months ago

The metadata of the grid is incorrect. It should not be TYPE=VERTICAL_OFFSET_VERTICAL_TO_VERTICAL, but TYPE=VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL

I also think we should let the previous file for reproducability for older transformations. The EPSG supersession mechanism should ensure the new grid is used by default, once it has made its way through EPSG.

rouault commented 10 months ago

@himsve You can drop the changes in the generated files (files.geojson, index.html) frmo the PR if that makes your life easier. I can easily refresh them on my side once this PR is merged. I suspect you might perhaps have some git issues with CRLF if you work on Windows.

rouault commented 10 months ago

@kbevers Is it fine to merge that right now in master, or will that cause trouble in your 1.16 release process?

kbevers commented 10 months ago

Is it fine to merge that right now in master, or will that cause trouble in your 1.16 release process?

I prefer that you wait until 1.16 is done