NN1954 and NN2000 added to PROJ-data

OSGeo / PROJ-data

Repository for proj datum grids (for use by PROJ 7 or later)

Other

72 stars 33 forks source link

Closed himsve closed 3 years ago

rouault commented 3 years ago

Looks quite close to be ready: Two small observations valid for the 2 tiff files:

a warning to address if possible: "TIFF tag DateTime malformed. Should be YYYY:MM:DD HH:MM:SS"
Could I suggest to put the CRS names as well as the CRS code in TIFFTAG_IMAGEDESCRIPTION, like done for other grids ? For example instead of "EPSG:4937 to EPSG:5941. Converted from HREF2018B_NN2000_EUREF89.gtx." --> "EPSG:4937 (ETRS89) to EPSG:5941 (NN2000 height). Converted from HREF2018B_NN2000_EUREF89.gtx."

rouault commented 3 years ago

Anything left on your side ? This looks good to me otherwise

meastp commented 3 years ago

@himsve @rouault Is this ready to merge now? :)

rouault commented 3 years ago

Is this ready to merge now? :)

The PR should be rebased on top of current master. There are conflicts in some generated files

himsve commented 3 years ago

The pull request should be ready for merging. The last update is to put to a branch named 'typo'.