gdal2tile.py pool not closed in case of failure

[zeevdr]

The pool opened in https://github.com/OSGeo/gdal/blob/95c9d336b2db0c5d240f191638c116c37fd8bb02/swig/python/gdal-utils/osgeo_utils/gdal2tiles.py#L3299

Will not be closed if an exceptio occurs before https://github.com/OSGeo/gdal/blob/95c9d336b2db0c5d240f191638c116c37fd8bb02/swig/python/gdal-utils/osgeo_utils/gdal2tiles.py#L3337

should add try/finally.

Somthing like:

    if pool is not None:
        ...
        created_pool = False
    else:
        ...
        pool = Pool(processes=nb_processes)
        created_pool = True
    try:
        ...
    finally:
        if created_pool:
            pool.terminate()

[rouault]

can you submit a pull request for that ?

[zeevdr]

@rouault will do, once I have the time

[rouault]

@jcphill would you be interested in implementing this ? The above proposal that relies on calling pool.terminate() will require some monkey patching of the MPI pool object to provide a terminate() method

[jcphill]

Sure, although I'll probably refactor to use a with statement rather than try/finally/terminate/close/join.

[jcphill]

@zeevdr I'd appreciate your comments on https://github.com/OSGeo/gdal/pull/5675