search

OSGeo / gdal

GDAL is an open source MIT licensed translator library for raster and vector geospatial data formats.
https://gdal.org
Other
4.9k stars 2.55k forks source link

Feature Request [GML]: Make "Use geometry in boundedBy element" an open option #7947

Closed pathmapper closed 1 year ago

pathmapper commented 1 year ago

What was the intention for the change in https://github.com/OSGeo/gdal/pull/7133?

If it doesn't conflict with the original intention, maybe make it an open option with default = false?

Came across this because there is a need to adapt an XPlanung QGIS plugin to restore the original behaviour, if this change stays like it is currently (with XPlanung-schema it happens often that there is a feature with bbox but without geoemtry).

Also, currently there might be confusion, e.g. when you drag'n drop a GML like the test data from #7925 in QGIS, the import dialog shows a polygon feature for BP_Bereich without notifying the user that this is the bbox and not the actual feature geometry (or that the layer has no feature with geometry).

rouault commented 1 year ago

What was the intention for the change in #7133?

There are some data models like https://github.com/rouault/gdal/blob/a35c3ab224f55dce7af060a1d1b7279fec24dbf8/autotest/ogr/data/gml/only_boundedby.gml which is a simplified version of some Ordnance Survey files where getting the bbox as a geometry was desirable

If it doesn't conflict with the original intention, maybe make it an open option with default = false?

I must check with the user who requested the behaviour of #7133

rouault commented 1 year ago

ok, so the user confirmed a "-oo USE_BBOX=YES" would work for him