OSGeo / gdal

GDAL is an open source MIT licensed translator library for raster and vector geospatial data formats.
https://gdal.org
Other
4.63k stars 2.45k forks source link

typo: CPL_SUPRESS_CPLUSPLUS → CPL_SUPPRESS_CPLUSPLUS #8753

Open schwehr opened 7 months ago

schwehr commented 7 months ago

I see it as of 208d0cdb35cc4f790f516eb7a3a88a1d9149a2ed / 2023-Nov-19

"supress" should be "suppress"

It was added to fix_typos.sh in https://github.com/OSGeo/gdal/commit/d3e82a272d2

Is there a reason that the typo should remain?

rouault commented 7 months ago

I see it as of 208d0cd / 2023-Nov-19

"supress" should be "suppress"

where ? can't see any match with:

wget https://github.com/OSGeo/gdal/commit/208d0cdb35cc4f790f516eb7a3a88a1d9149a2ed.patch
grep supress 208d0cdb35cc4f790f516eb7a3a88a1d9149a2ed.patch

or maybe you're talking about the whole code base at that revision? But I don't see any match for supress but in the flatbuffers vendored code

It was added to fix_typos.sh in https://github.com/OSGeo/gdal/commit/d3e82a272d2

where ? I only see CPL_SUPRESS_CPLUSPLUS, and that one is used in external code like QGIS

rouault commented 7 months ago

oh forget the first part of my above comment. I didn't notice the issue title ;-)