OSGeo / grass-addons

GRASS GIS Addons Repository
https://grass.osgeo.org/grass-stable/manuals/addons/
GNU General Public License v2.0
98 stars 148 forks source link

i.eodag: add query, print, and footprints options #1136

Closed HamedElgizery closed 1 month ago

HamedElgizery commented 2 months ago

Note: Queryables from the above list can then be used in the query option.

ninsbl commented 2 months ago

I think the additional queryables need to be used in the crunch function on the returned initial surchresults, not during initial surch.

As for implementing the queriables, please consider the different operators and possible use of multiple values. Please double check also my earlier suggestions.

HamedElgizery commented 1 month ago

I've just tested different use cases. In generally, it works as expected, except for the query option. I tried with OrbitDirection and start, but nothing gets filtered really with those... so, I'm not sure it actually works or how it is supposed to work (the queryables for S2 will return mostly the same values, because they are like organization, instrument and so on...).

Thanks for the testing! I am currently working on fixing the issue.

In general, I'm in to merge this one as it got too long already (maybe smaller PRs are easier to review and test), and if there's something else to fix, create a new PR.

Makes sense, I will be pushing the fix on the next PR if we agree on that, which will also extend on the current query functionality.