OSGeo / grass-addons

GRASS GIS Addons Repository
https://grass.osgeo.org/grass-stable/manuals/addons/
GNU General Public License v2.0
103 stars 154 forks source link

[Bug] r.learn.ml2: test_append failure #495

Closed neteler closed 2 years ago

neteler commented 3 years ago

At time this test fails:

Test      | test_append
Testsuite | ./raster/r.learn.ml2
Test file | ./raster/r.learn.ml2/testsuite/test_append.py
Status    | FAILED

Standard error output (stderr)

..x.ERROR: lsat7_2002_10@landsat: Cannot remove or exclude files not in the current mapset.
E
======================================================================
ERROR: tearDownClass (__main__.TestAppend)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "raster/r.learn.ml2/testsuite/test_append.py", line 46, in tearDownClass
    gs.run_command("g.remove", type="raster", name=cls.other, flags="f")
  File "etc/python/grass/script/core.py", line 543, in run_command
    return handle_errors(returncode, result=None, args=args, kwargs=kwargs)
  File "etc/python/grass/script/core.py", line 428, in handle_errors
    raise CalledModuleError(module=module, code=code, returncode=returncode)
grass.exceptions.CalledModuleError: Module run g.remove g.remove -f type=raster name=lsat7_2002_10@landsat ended with error
Process ended with non-zero return code 1. See errors in the (error) output.

----------------------------------------------------------------------
Ran 4 tests in 0.174s

FAILED (errors=1, expected failures=1)

The problem might be that here the @landsat part is given:

https://github.com/OSGeo/grass-addons/blob/a5ec8b618f2cb6cc65c4f9aad194b6c5aa2fe8ac/grass7/raster/r.learn.ml2/testsuite/test_append.py#L40

Since the test runs in another mapset, this original map cannot be removed (and should not) in tearDownClass(). Might be easy to fix...

Log source: GitHub actions

stevenpawley commented 2 years ago

Fixed with #645