OSGeo / grass-addons

GRASS GIS Addons Repository
https://grass.osgeo.org/grass-stable/manuals/addons/
GNU General Public License v2.0
103 stars 154 forks source link

i.superpixel.slic extension not found #581

Closed mkieser closed 2 years ago

mkieser commented 3 years ago

Name of the addon i.superpixel.slic

Describe the bug I run the g.extension i.superpixels.slic command and the URL https://github.com/OSGeo/grass-addons/trunk/grass7/imagery/i.superpixels.slic doesn't exist. I've also tried the command with the full URL g.extension i.superpixels.slic url="https://github.com/OSGeo/grass-addons/tree/grass7/src/imagery/i.superpixels.slic" branch="grass7" and the extension is not found.

To Reproduce Steps to reproduce the behavior:

  1. Run g.extension i.superpixels.slic
  2. See erros
  3. Run g.extension i.superpixels.slic url="https://github.com/OSGeo/grass-addons/tree/grass7/src/imagery/i.superpixels.slic" branch="grass7"
  4. See error

Expected behavior I expect that the i.superpixels.slic extension will be added from the GitHub URL

Screenshots N/A

System description (please complete the following information):

Additional context N/A

veroandreo commented 3 years ago

I'm experiencing the same with GRASS 7.8.5 (current stable) and grass dev recompiled as of today too. AFAIU the addon installation is failing since the re-structuring of grass-addons repo in #571 (or at least I cannot find the proper parameter specification to make it work).

But the problem is with g.extension that needs to be fixed accordingly and not the addons themselves. There's a draft PR that tackles this: https://github.com/OSGeo/grass/pull/1700

ninsbl commented 3 years ago

The problem is probably that grass7 now is the default branch (more than that the grass7 branch got restructured). "trunk" in the URL refers to the default branch.

When the branch concept got included in g.extension, unfortunately, main and master were treated as if they allways would be the default branches, which is what now causes trouble...

Will try to get #1700 ready to merge ASAP...

tgrippa commented 3 years ago

Hi all, Same problem for me here. Do you know if the issue will be solved in 7.8.5 or I would have to use grass dev and compile myself when the source code will be fixed ? Thanks

veroandreo commented 3 years ago

Grass 7.8.5 is the current stable and because of addon repo restructuring, g.extension is momentarily not working. It should be solved for 7.8.6, this is a blocker of the release indeed.

carolxgl commented 3 years ago

Hi all, I have the same problem when trying: g.extension r.forestfrag .

wenzeslaus commented 3 years ago

If you are comfortable with JupyterLab you can test OSGeo/grass#1700 using Binder (link). Click File > New > Terminal and type:

grass data/grassdata/nc_basic_spm_grass7/user1
g.extension r.clip
ninsbl commented 3 years ago

FYI: https://github.com/OSGeo/grass/pull/1700 has been merged into master.

ninsbl commented 2 years ago

I think this can be closed as fixed. Can you confirm @mkieser ?