Closed echoix closed 2 years ago
Note: It appears that also other addons require a related update (both in code and HTML manuals):
ag -l '\.grass7'
general/g.cloud/cloud_collect.sh
general/g.cloud/test/launch_SGE_grassjob.sh
general/g.cloud/g.cloud.py
imagery/i.modis/i.modis.download/i.modis.download.html
raster/r.diversity/r.diversity.py
raster/r.stream.variables/r.stream.variables.sh
raster/r.stream.watersheds/r.stream.watersheds.sh
tools/mk_isis_menu.README
tools/mk_isis_menu.sh
Easy to fix, but ideally, there would be an API to obtain that path.
Name of the addon r.diversity
Describe the bug The
r.diversity
addon seams to add additional checks and builds a path to a config directory using an hardcoded "GRASS7
" or ".grass7
" string. In the imminent release of GRASS 8, this should lead to a compatibility issue.To Reproduce Steps to reproduce the behavior:
GRASS7
folders inAPPDATA
on Windows, or no.grass7
folder in the user profile for others like Linux)g.extension r.diversity
.r.diversity input=ndvi_map prefix=diversity alpha=0.5
(from the manual page)Expected behavior
r.diversity
should install and run in GRASS 8 like it did on GRASS 7Screenshots See the following lines in the addon's source code: https://github.com/OSGeo/grass-addons/blob/b7a36ebd8001fc77cdf11d8673e4dc7b8ec2fdef/src/raster/r.diversity/r.diversity.py#L86-L101
System description (please complete the following information): I don't have a GRASS 8 only installation to confirm issue, so irrelevant (sorry).
Additional context I observed this potential issue when proofreading the raster addons recently.
Originally posted by @echoix in https://github.com/OSGeo/grass-addons/issues/664#issuecomment-1008345218