search

OSGeo / grass-addons

GRASS GIS Addons Repository
https://grass.osgeo.org/grass-stable/manuals/addons/
GNU General Public License v2.0
103 stars 154 forks source link

[Question] Keeping Last changed commented in manual pages #684

Closed echoix closed 2 years ago

echoix commented 2 years ago

Since PRs osgeo/grass#2100, osgeo/grass#2110, osgeo/grass#2111, osgeo/grass#2113,osgeo/grass#2110 added automatic inclusion of dates in the manual pages, I'm asking if newer (addons) manual pages should keep the old <p> <i>Last changed: $Date$</i> commented out or remove the HTML comment when updating the pages.

If they are to remove, is it better to remove all of them in one commit (all of them will have the same date), or incrementally when changing files?

I'm still following up on the spelling fixes long-term chore. Sorry if I chose an issue here to ask even if it's not a bug, I didn't find a better place for this.

echoix commented 2 years ago

Perhaps I could use some guidelines, like from @neteler? Is someone else qualified to suggest?

neteler commented 2 years ago

For me no longer a need to keep the commented entries.

@ninsbl do you need them or shall we remove them everywhere in core and addons?

If to be removed, then I suggest an all-in-one single commit.

echoix commented 2 years ago

Ok, that's good for me! If @ninsbl has the same opinion, we can close this and add this to a better todo list, since it won't be a question anymore, but rather a task to do.

ninsbl commented 2 years ago

I dont think they are needed any more. g.citation would need some adjustment, but I am on that in #677. So, please go ahead and remove