search

OSGeo / grass

GRASS GIS - free and open-source geospatial processing engine
https://grass.osgeo.org
Other
852 stars 309 forks source link

[Feat] Add r.accumulate as default module #1900

Open ar-siddiqui opened 3 years ago

ar-siddiqui commented 3 years ago

Is your feature request related to a problem? Please describe. I would like to use r.accumulate in QGIS, for this to happen r.accumulate should be a default module in GRASS.

Describe the solution you'd like r.accumulate to be a default module in GRASS.

Describe alternatives you've considered I have considered using r.watershed but that takes a dem as input, I am writing a workflow to process the same DEM with different weights to get flow accumulation, if I use r.watershed it calculates flow direction every time which makes the whole process is slow

Additional context QGIS developers response for a similar request: https://github.com/qgis/QGIS/issues/35481

HuidaeCho commented 3 years ago

@veroandreo Do we have any guidelines for migrating addons to the core? Is it just a matter of creating a PR like https://github.com/OSGeo/grass/pull/1918? Any consensus over this?

veroandreo commented 3 years ago

@veroandreo Do we have any guidelines for migrating addons to the core? Is it just a matter of creating a PR like #1918? Any consensus over this?

I darkly remember to have seen something in trac? Anyway, I believe that if the module have tests, following @petrasovaa's approach should work. If people have objections they can always comment in the PR.