OSGeo / grass

GRASS GIS - free and open-source geospatial processing engine
https://grass.osgeo.org
Other
831 stars 302 forks source link

[Bug] wxGUI: unclear error message in scatterplot with non-overlapping raster maps #2044

Open neteler opened 2 years ago

neteler commented 2 years ago

Describe the bug

When attempting to draw an scatterplot, the plot is not shown:

wxpython_scatterplot_not_shown

To Reproduce Steps to reproduce the behavior:

1) load two elevation maps from NC sample dataset:

Settings: unable to get value 'scatter:rasters:None'

System description (please complete the following information):

System Info

GRASS version: 8.0.dev
Code revision: ff485ffdc                                                        
Build date: 2021-12-14                                                          
Build platform: x86_64-pc-linux-gnu                                             
GDAL: 3.3.2                                                                     
PROJ: 8.2.0                                                                     
GEOS: 3.9.2                                                                     
SQLite: 3.36.0                                                                  
Python: 3.10.1                                                                  
wxPython: 4.0.7                                                                 
Platform: Linux-5.15.6-200.fc35.x86_64-x86_64-with-glibc2.34
petrasovaa commented 2 years ago

This actually works for me.

neteler commented 2 years ago

This actually works for me.

When I select two maps in the Layers tab, then it works. When I select two maps in the scatterplot dialog, it doesn't (with above error msg)... Can anyone confirm this?

petrasovaa commented 2 years ago

The 2 raster maps you used don't overlap, try e.g. elevation and elev_srtm_30m.

neteler commented 2 years ago

The 2 raster maps you used don't overlap,

Ops.

try e.g. elevation and elev_srtm_30m.

Yes, then it works. So, this would be a shy wish for a better user message.

I guess that it needs to be checked earlier than here: https://github.com/OSGeo/grass/blob/b62830ba8519dc68f9d1df1f128c7d27bc217695/gui/wxpython/core/settings.py#L1068