echoix
commented
1 month ago I wanted to reproduce with an nightly build of the upcoming 8.4, but I can't get an installation launching for now (bugs are filed in).
Open carnendil opened 1 month ago
echoix
commented
1 month ago I wanted to reproduce with an nightly build of the upcoming 8.4, but I can't get an installation launching for now (bugs are filed in).
agiudiceandrea
commented
1 month ago The issue occurs also using GRASS-GIS 8.4.0-dev f4d8c62ac (OSGeo4W).
echoix
commented
1 month ago So it's still a valid bug to look into.
echoix
commented
1 month ago Hmm.. I'm not able to make the module run correctly, but it isn't because of loading a dll or segfault or the sort. I'm using grass-dev 8.4-313-f4d8c62ac-1 from OSGeo4W, without QGIS, on a fresh OS install (windows sandbox), + installed missing gdal308-runtime + patch of #3732
I set the projection to WGS84 UTM17N as the data from the issue in the QGIS repo.
I don't know what the Interpolated RST [optional] -> Save to file...: output-raster.sdat { sdat file type selected by default } option mapped to, but I chose the options as below, and got the result as above.
So, is it true that the data points aren't in the mask, or that's a problem?
neteler
commented
1 month ago @echoix: does the v.surf.rst manual page example work for you?
echoix
commented
1 month ago @echoix: does the v.surf.rst manual page example work for you?
Not really.
After making sure I had the north carolina dataset, and found out how to switch to it, it was r.random at the beginning that errored out. It absolutely wanted -s or seed, exited non-zero.
Adding that, I was able to go up to the first v.surf.rst call. A couple warnings, overshoots, and finishes non-zero.
498|84.681931
499|76.610321
500|97.182198
(Sun May 26 17:20:50 2024) Command finished (1 sec)
(Sun May 26 17:20:59 2024)
v.surf.rst elevrand zcol=value elevation=elev_full
Reading features from vector map ...
WARNING: There are less than 600 points for interpolation. No segmentation is necessary, to run the program faster set segmax=600 (see manual)
Processing all selected output files will require
7.73 MB of disk space for temp files.
Processing segments in parallel...
Starting parallel work
G_ludcmp() failed! n=0 d=0.00
WARNING: Overshoot - increase in tension suggested. Overshoot occurs at (456,339) cell. Z-value 60032.884815, zmin 57.113735, zmax 155.267105.
(Sun May 26 17:21:11 2024) Command ended with non-zero return code 3221226356 (11 sec)
(Sun May 26 17:21:25 2024)
r.colors elev_full raster=elevation
ERROR: Raster map <elev_full> not found
(Sun May 26 17:21:27 2024) Command ended with non-zero return code 1 (0 sec)
```
(Sun May 26 17:20:04 2024)
g.region raster=elevation -p
projection: 99 (Lambert Conformal Conic)
zone: 0
datum: nad83
ellipsoid: a=6378137 es=0.006694380022900787
north: 228500
south: 215000
west: 630000
east: 645000
nsres: 10
ewres: 10
rows: 1350
cols: 1500
cells: 2025000
(Sun May 26 17:20:05 2024) Command finished (0 sec)
(Sun May 26 17:20:12 2024)
r.random elevation vector_output=elevrand n=500
WARNING: Please update the usage of
agiudiceandrea
commented
1 month ago v.surf.rst doesn't crash, with the same inputs and parameters, using GRASS-GIS 7.8.6.
agiudiceandrea
commented
1 month ago installed missing gdal308-runtime
@echoix, see https://trac.osgeo.org/osgeo4w/ticket/835.
echoix
commented
1 month ago @agiudiceandrea Can you link in that ticket issues https://github.com/OSGeo/grass/issues/3738 and https://github.com/OSGeo/grass/issues/3739? I'm not sure my trac credentials are still working right now.
neteler
commented
1 month ago After making sure I had the north carolina dataset, and found out how to switch to it, it was r.random at the beginning that errored out. It absolutely wanted
-sor seed, exited non-zero.
I have corrected/updated the v.surf.rst example in #3743.
agiudiceandrea
commented
1 month ago @echoix, the gdal308/gdal309 OSGeo4W packaging issue is fixed now since grass-dev-8.4-314-f3ccff668-1.
echoix
commented
1 month ago The issue occurs also using GRASS-GIS 8.4.0-dev f4d8c62ac (OSGeo4W).
I have a question about this. How did you test that to get this fact? If it was through QGIS, how do you know that installing grass-dev 8.4.0-dev f4d8c62ac (OSGeo4W) is enough for QGIS to pick it up correctly?
agiudiceandrea
commented
1 month ago How did you test that to get this fact?
I installed GRASS-GIS 8.4.0-dev https://github.com/OSGeo/grass/commit/f4d8c62acd9bb6a65854a111ea73380f7760b838 (grass-dev 8.4-313-f4d8c62ac-1 package) on Windows 10 Home 64-bit using he OSGeo4W Setup also installing the gdal308-runtime package and patching the tree.py file as per https://github.com/OSGeo/grass/pull/3732, Then I used the GRASS-GIS 8.4.0-dev GUI and executed v.surf.rst with the layers and parameters provided by you.
neteler
commented
1 month ago @echoix: does the v.surf.rst manual page example work for you?
Not really.
It's now fixed in "main".
hellik
commented
1 month ago tested here with
System Info
GRASS version: 8.3.2
Code revision: exported
Build date: 2024-05-20
Build platform: x86_64-w64-mingw32
GDAL: 3.9.0
PROJ: 9.4.0
GEOS: 3.12.1
SQLite: 3.45.1
Python: 3.12.4
wxPython: 4.2.1
Platform: Windows-11-10.0.22631-SP0 (OSGeo4W)the first example in the 8.3 manual works on that machine
hellik
commented
1 month ago trying it with
GRASS version: 8.5.0dev
Code revision: 3c66b4f08
Build date: 2024-06-15
Build platform: x86_64-w64-mingw32
GDAL: 3.9.0
PROJ: 9.4.0
GEOS: 3.12.2
SQLite: 3.45.1
Python: 3.12.4
wxPython: 4.2.1
Platform: Windows-11-10.0.22631-SP0 (OSGeo4W)antivirus/firewall complains about v.surf.rst.exe.
could be the original report also related to antivirus/firewall ?
agiudiceandrea
commented
4 weeks ago @hellik, on a Windows 10 Home 64-bit version 1903 build 18362.778 without any antivirus/firewall software running, the issue still occurs using GRASS-GIS version 8.5.0dev 0b0cffce0 (OSGeo4W): v.surf.rst.exe crashes with the input layers and parameters provided at https://github.com/qgis/QGIS/issues/57523#issuecomment-2130281545.
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
<System>
<Provider Name="Application Error" />
<EventID Qualifiers="0">1000</EventID>
<Level>2</Level>
<Task>100</Task>
<Keywords>0x80000000000000</Keywords>
<TimeCreated SystemTime="2024-06-16T14:29:20.461583500Z" />
<EventRecordID>199984</EventRecordID>
<Channel>Application</Channel>
<Security />
</System>
<EventData>
<Data>v.surf.rst.exe</Data>
<Data>8.5.0.0</Data>
<Data>666e197e</Data>
<Data>ntdll.dll</Data>
<Data>10.0.18362.778</Data>
<Data>0c1bb301</Data>
<Data>c0000374</Data>
<Data>00000000000f9229</Data>
<Data>3da4</Data>
<Data>01dabff992c76bd4</Data>
<Data>C:\OSF9FA~1\apps\grass\grass85\bin\v.surf.rst.exe</Data>
<Data>C:\WINDOWS\SYSTEM32\ntdll.dll</Data>
<Data>c235f87a-fbd9-4860-83a9-4fe7969d05ab</Data>
<Data />
<Data />
</EventData>
</Event>
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
<System>
<Provider Name="Application Error" />
<EventID Qualifiers="0">1000</EventID>
<Level>2</Level>
<Task>100</Task>
<Keywords>0x80000000000000</Keywords>
<TimeCreated SystemTime="2024-06-16T14:29:20.461583500Z" />
<EventRecordID>199984</EventRecordID>
<Channel>Application</Channel>
<Security />
</System>
<EventData>
<Data>v.surf.rst.exe</Data>
<Data>8.5.0.0</Data>
<Data>666e197e</Data>
<Data>ntdll.dll</Data>
<Data>10.0.18362.778</Data>
<Data>0c1bb301</Data>
<Data>c0000374</Data>
<Data>00000000000f9229</Data>
<Data>3da4</Data>
<Data>01dabff992c76bd4</Data>
<Data>C:\OSF9FA~1\apps\grass\grass85\bin\v.surf.rst.exe</Data>
<Data>C:\WINDOWS\SYSTEM32\ntdll.dll</Data>
<Data>c235f87a-fbd9-4860-83a9-4fe7969d05ab</Data>
<Data />
<Data />
</EventData>
</Event><Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
<System>
<Provider Name="Windows Error Reporting" />
<EventID Qualifiers="0">1001</EventID>
<Level>4</Level>
<Task>0</Task>
<Keywords>0x80000000000000</Keywords>
<TimeCreated SystemTime="2024-06-16T14:29:23.251755900Z" />
<EventRecordID>199986</EventRecordID>
<Channel>Application</Channel>
<Security />
</System>
<EventData>
<Data>1906747485877836679</Data>
<Data>4</Data>
<Data>APPCRASH</Data>
<Data>Non disponibile</Data>
<Data>0</Data>
<Data>v.surf.rst.exe</Data>
<Data>8.5.0.0</Data>
<Data>666e197e</Data>
<Data>StackHash_30cd</Data>
<Data>10.0.18362.778</Data>
<Data>0c1bb301</Data>
<Data>c0000374</Data>
<Data>PCH_77_FROM_ntdll+0x000000000009CBC4</Data>
<Data />
<Data />
<Data>\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERFDA8.tmp.dmp \\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERFF30.tmp.WERInternalMetadata.xml \\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERFF60.tmp.xml \\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERFF6F.tmp.csv \\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERFFDE.tmp.txt</Data>
<Data>\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_v.surf.rst.exe_7676a37ce65155b079b3ae7028ca59b793e3633d_4d9243d9_6bf96f05-efdb-4ce3-8270-0f4db5c30e22</Data>
<Data />
<Data>0</Data>
<Data>c235f87a-fbd9-4860-83a9-4fe7969d05ab</Data>
<Data>268435456</Data>
<Data>8fc689e424817ea4ea7620bc6c1e1b87</Data>
<Data>0</Data>
</EventData>
</Event>
Describe the bug
As reported here, running
v.surf.rstin QGIS on MS Windows 10, results in the following error and the output file is not created:The problem has been traced to
To reproduce
v.surf.rstalgorithm..gpkglayer in my case)..sdatraster containing a single polygon. All points are contained within that polygon.All the algorithm parameters
input-points.gpkgfield_3input-mask-raster.sdat40.000000{ default }40{ default }300{ default }1.000000{ default }0.000000{ default }-1.000000{ default }0.000100{ default }auto{ default }output-raster.sdat{ sdat file type selected by default }Expected behavior
Creation of a raster with the interpolated RST.
System description
Operating System: Windows 10
GRASS GIS version: 8.3.2
details about further software components
Additional context
I also tried with a different dataset, one for which in Feb. 2023 (possibly QGIS 3.28) the very same procedure had worked perfectly. This time I got the same error described above. It shows that is not a problem with the data, but QGIS/GRASS behaving differently.
The algorithm ran without major problems in Ubuntu (same data, same QGIS version, GRASS 8.3.0)