search

OSGeo / grass

GRASS GIS - free and open-source geospatial processing engine
https://grass.osgeo.org
Other
791 stars 288 forks source link

style: Fix single-line-implicit-string-concatenation violations (ISC001) #3943

Closed echoix closed 2 days ago

echoix commented 3 days ago

I finished creating the new pylint 3 config for https://github.com/OSGeo/grass/issues/3921. There are too many violations to be useful to file right away.

So here is a first PR that applies a single fix throughout the code base, but it doesn't fix all of them.

The pylint violation in question is W1404: Implicit string concatenation found in assignment (implicit-str-concat) A similar rule supported by ruff is single-line-implicit-string-concatenation (ISC001), derived from the flake8-implicit-str-concat linter.

This PR only applies safe fixes with ruff check --select "ISC001" --fix in order to limit the review scope to the obviously correct fixes. These kinds of formatting issues most probably come from different python formatting tool versions throughout the years, like black.

I kept applying the fix and then applying black separate in two commits, in order to review the fixes of the first commit only, and simply approving the black formatting.

I'd like for this to not stay pending too long, as there shouldn't be anything to discuss or contest in this.

echoix commented 3 days ago

There are 11 other non-automatic fixes to apply in another PR