search

OSGeo / grass

GRASS GIS - free and open-source geospatial processing engine
https://grass.osgeo.org
Other
852 stars 310 forks source link

docker: Sort package lists and configure options in Dockerfiles #4373

Closed echoix closed 1 month ago

echoix commented 1 month ago

Package lists were unsorted, and I got tricked when adding liblapacke-dev and sorting the list thinking it was sorted (almost but not). Being unsorted makes finding a package harder. To prove this point, zlib1g-dev was listed twice in the same list because it was unsorted.

I simply used the sort lines feature of my IDE, VSCode, that is case-sensitive.

echoix commented 1 month ago

Let's wait a day or so, to let Europeans have the chance to look

neteler commented 1 month ago

Would it make sense, while at it, to also sort:

?

echoix commented 1 month ago

What are those already? Is it related to docker?

To do in the same PR or another?

neteler commented 1 month ago

Vagrant: https://grasswiki.osgeo.org/wiki/Vagrant, added by @landam

Singularity is for HPC environments, added by @lucadelu

If here or elsewhere, I cannot judge.

echoix commented 1 month ago

Ok, I took a quick look at it, and I'll do another PR for it, that would also do other build script that has the configure calls.

So since it isn't docker related anymore, let's just start with this one that is ready to go.