OSGeo / grass

GRASS GIS - free and open-source geospatial processing engine
https://grass.osgeo.org
Other
854 stars 311 forks source link

style: Sort package lists, configure options, and other various sortable files #4563

Closed echoix closed 4 weeks ago

echoix commented 1 month ago

Follow up from last month's #4373.

This PR sorts sortable parts of many remaining files. Build scripts, package lists, file lists, contributors lists, etc. I made some searches on what looked like configure flags, and packages too.

About the only thing that wasn't sorted was everything in Makefiles, like directory lists or other lists in Makefiles, and the mingw64 packages in the osgeo4w.yml workflow, as the packages weren't placed in a line-delimited list yet

neteler commented 1 month ago

Thanks for your efforts.

We have a number of CSV files, perhaps some could be merged? Their origin is from CVS/SVN times with a different than GitHub write access model which is no longer in place:

In case of structural changes (e.g., merging selectively) also a GUI change would be needed:

wxpython/gui_core/ghelp.py

            contribfile = os.path.join(os.getenv("GISBASE"), "contributors_extra.csv")
            contribfile = os.path.join(os.getenv("GISBASE"), "contributors.csv")
        translatorsfile = os.path.join(os.getenv("GISBASE"), "translators.csv")
                label=_("%s file missing") % "translators.csv",

However, maybe better done in a separate PR.

echoix commented 1 month ago

Thanks for your efforts.

We have a number of CSV files, perhaps some could be merged? Their origin is from CVS/SVN times with a different than GitHub write access model which is no longer in place:

  • contributors.csv
  • contributors_extra.csv
  • translators.csv
  • utils/git_author_github_name.csv
  • utils/svn_name_git_author.csv
  • utils/svn_name_github_name.csv

In case of structural changes (e.g., merging selectively) also a GUI change would be needed:

wxpython/gui_core/ghelp.py

            contribfile = os.path.join(os.getenv("GISBASE"), "contributors_extra.csv")
            contribfile = os.path.join(os.getenv("GISBASE"), "contributors.csv")
        translatorsfile = os.path.join(os.getenv("GISBASE"), "translators.csv")
                label=_("%s file missing") % "translators.csv",

However, maybe better done in a separate PR.

I made a separate issue for it https://github.com/OSGeo/grass/issues/4599, as indeed, it is kind of a different topic than this PR.