Open arohanajit opened 2 weeks ago
@echoix any suggestions here? Upstream has no fix for it. It's not used.
@echoix any suggestions here? Upstream has no fix for it. It's not used.
I'd need to have a deep look for this, as it might be impactful. I think we needed to revert one of my PRs that touched this if I remember well.
I'd be cautious and read well. Was it @wenzeslaus that has experience with this file?
wrt to #1809 This PR updates the
__cmp__
method insaferef.py
to be compatible with Python 3. Comparison methods__eq__
and__lt__
are implemented to maintain the same functionality without requiring changes elsewhere in the code.Changes:
__eq__
method for equality comparison.__lt__
method for less-than comparison.__cmp__
method now uses the rich comparison methods for its logic.This shouldn't change overall behavior of
saferef
class.