search

OSGeo / grass

GRASS GIS - free and open-source geospatial processing engine
https://grass.osgeo.org
Other
855 stars 310 forks source link

wxGUI: Removed PEP8 errors from rlisetup/ #4693

Closed arohanajit closed 1 week ago

arohanajit commented 1 week ago

Removed following errors:

echoix commented 1 week ago

I have a question on this. I tried to understand the pattern in the file, to see if there was a side effect of getting the first item (I don't think there is). It seems that item is used in the other methods to set hide to true to set the coords or region. Why isn't the coords used here, or how is it used? The docstring says that the region is "get"-ted, but the function does not return a value, and unlike the rectangle drawn method, it doesn't set a region.

Side note: I see that a public method is named createCricle, which probably should be createCircle. What are the compatibility guarantees that we offer inside our own gui code?

petrasovaa commented 1 week ago

I have a question on this. I tried to understand the pattern in the file, to see if there was a side effect of getting the first item (I don't think there is). It seems that item is used in the other methods to set hide to true to set the coords or region. Why isn't the coords used here, or how is it used? The docstring says that the region is "get"-ted, but the function does not return a value, and unlike the rectangle drawn method, it doesn't set a region.

I agree it looks somewhat suspicious, but honestly I don't have time to test this, it's not an important component.

Side note: I see that a public method is named createCricle, which probably should be createCircle. What are the compatibility guarantees that we offer inside our own gui code?

No guarantees for GUI

echoix commented 1 week ago

Thanks @petrasovaa for your answers!