[Feat] Support dark theme

[marisn]

As there is this new fad of turning everything dark, we could ride the wave while it's all hype. This could be the eye candy required to help sell GRASS 8.0

On a user request I was testing GRASS with dark theme — only minor adjustments are needed. Still, proper dark theme support is possible only with >=wxPython-4.1 + =>wxWidgets-3.1.3, as it starts to provide wx.SystemAppearances with IsDark test to see if dark theme should be enabled automatically.

Missing places (added by @wenzeslaus):

• [ ] Query results window
  • Map Display toolbar > Query raster/vector map(s)
  • Most of the text is black when system text color is light.
  • Seems to be wxPython issue, see #1186
• [x] Console tab > Command input box (aka Prompt) #1217
  • Uses black on white regardless of the theme.
  • Present also in Graphical Modeler
• [ ] #1863
  • Certain ways of clicking (not clear to me which ones) cause the line/item to be very dark with black text (beyond reading) with (at least some) dark themes.
  • One way how to reproduce the state consistently seems to be right clicking and clicking Properties in the menu.

  • 1187

• [x] Display tab - the Display 1, Display 2, ... tabs at the top
  • Tab itself is gradient making the text hard to read.
  • Background is green-white gradient which doesn't fit with the rest.
  • The style needs redoing regardless of the dark theme issue. Any plain tab style is probably fine.
  • Addressed in #1801
• [x] Map Display user-set default background color, done in #1167
  • Manually set background color is not respected on with no layers (e.g., on startup), only when rendering.
  • If the default should be set by the system is questionable, but if the user decides to set the color, it should be used always.
• [x] Attribute table manager
  • Layer/Table tabs use the green-white gradient style.
  • SQL Query tabs use the white-gray gradient style.
  • Browse data/Manage tables/... tabs use the white-gray gradient style.
  • Addressed in #1801
• [x] Graphical Modeler
  • The main Model/Items/Variables/... tabs use the white-gray gradient style - addressed in #1801
  • Python editor (see below) - done in #1220
  • [ ] #2997
• [x] Python tab, see #1220
  • Uses black on white, so does not fit when dark theme is used.
  • Since it is "coding", making it always dark is probably aesthetically fine and expected behavior for most users. (It may do harm to those who use a light theme with color inversion.)
• [x] Simple Python Editor, see #1220
  • Same as Python tab
  • Present also in Graphical Modeler
• [x] About GRASS GIS
  • Help > About GRASS GIS
  • Tabs Info, Translators, and Translation status seem to use theme font color (light) but use hard-coded background (white).
  • Done in #1215
• Other and unsorted
  • [ ] #1851

Non-GUI:

• [x] Manual pages
  • Don't work (go dark) with Dark Reader.
  • Perhaps due to badly defined CSS.
  • Marked as done, seems to be improved by Dark Reader, so assuming the HTML/CSS is good enough.

[petrasovaa]

You are talking about system-level dark theme, right? And just detecting that and tweaking some components to look good. wxPython 4.1 will be widespread by then, so that shouldn't be a big problem. Another thing would be to implement our own dark theme, that would be more work I think.

[marisn]

You are talking about system-level dark theme, right? And just detecting that and tweaking some components to look good. wxPython 4.1 will be widespread by then, so that shouldn't be a big problem. Another thing would be to implement our own dark theme, that would be more work I think.

Yes, I would go for system dark theme support. At the moment there are a few issues as in most of places UI colours are not hardcoded and thus dark theme works almost out of box.

[hellik]

would be a nice one

[wenzeslaus]

This would be great. It is more than an eye candy, more like eye protection. Now is the time to do it (it was not 9 years ago :-).

[petrasovaa]

Yes, I would go for system dark theme support. At the moment there are a few issues as in most of places UI colours are not hardcoded and thus dark theme works almost out of box.

@marisn, maybe you could update the description of this feature with more detailed analysis/observations of the problems? Possibly bugs to report to wxPython?

[petrasovaa]

See progress in #751.

[wenzeslaus]

I took the liberty to add a TODO list with what I was able to identify. Feel free to open separate issues (and PRs of course).