OSGeo / grass

GRASS GIS - free and open-source geospatial processing engine
https://grass.osgeo.org
Other
853 stars 311 forks source link

[Feat] r.carve add ability to select additional width and depth from columns in vector table #686

Open isaacullah opened 4 years ago

isaacullah commented 4 years ago

Is your feature request related to a problem? Please describe.

r.carve is part of the necessary routine to condition an (interpolated) DEM for hydrological modeling and landscape evolution. I am working to come up with a streamline preconditioning workflow to create the best possible hydrologically sound DEM for input into landscape evolution modeling with my r.landscape.evol addon module. I would like to use the output from r.stream.order to be able to carve different portions of a stream network to different depths and widths. For example, I want to be able to carve a trunk stream to say 2m depth and 30m width, feeder streams to 1m depth and 15m width, and branch streams to 0.5m depth and 5m width.

Describe the solution you'd like

I would like to have to new options in r.carve to select columns in the table for the amount of additional width and additional depth to be carved. These would be in addition to the currently available 'width' and 'depth' options, which will only accept single values for the entire stream network.

Describe alternatives you've considered

Right now, the only way to do this is the break the stream network vector lines file into different line files for the different levels of stream order (which can add up to MANY files for complex networks), then to run r.carve iteratively with each of these vector files, updating the width and depth options for each level of stream order.

neteler commented 4 years ago

@isaacullah can you please test #803?

neteler commented 4 years ago

@isaacullah can you please test #803?

.. gentle ping.

isaacullah commented 4 years ago

Hi Markus, I've been traveling and away from my computer. I'll be back by the end of next week and will give it a try. Thanks!!

Sent from my📱

On Sat, Aug 1, 2020, 9:22 AM Markus Neteler notifications@github.com wrote:

@isaacullah https://github.com/isaacullah can you please test #803 https://github.com/OSGeo/grass/pull/803?

.. gentle ping.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OSGeo/grass/issues/686#issuecomment-667555115, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDYS5DIPOYMRYHJNCHN3EDR6Q6ODANCNFSM4NQELTEQ .