CMake typo error

[nono303]

Hi ! quick typo fix in cmake: https://github.com/OSGeo/libgeotiff/blob/master/libgeotiff/CMakeLists.txt#L339 CMAKE_INSTALLL_BINDIR > CMAKE_INSTALL_BINDIR

[rouault]

yes, this has just been fixed per https://github.com/OSGeo/libgeotiff/pull/116 . A 1.7.3 release is imminent

[nono303]

Thx @rouault & sorry... didn't see it Fyi, here is my CMake patch (Windows build)

• IMPORT_SUFFIX without _i (seems like standard on Windows)
• don't install doc & man
  • ⏩ BUILD_DOC & BUILD_MAN options would be nice ;)

• install pdb if exist

  
  diff --git "a/libgeotiff/CMakeLists.txt" "b/libgeotiff/CMakeLists.txt"
  index ec02e0c..fe4922c 100644
  --- "a/libgeotiff/CMakeLists.txt"
  +++ "b/libgeotiff/CMakeLists.txt"
  @@ -244,12 +244,12 @@ SET(GEOTIFF_MAN_PAGES
  #    ${PROJECT_BINARY_DIR}/geotiff_version.h
  
  # Install doc files
  -INSTALL(FILES
  -    AUTHORS ChangeLog COPYING LICENSE README README_BIN README.WIN
  -    DESTINATION ${CMAKE_INSTALL_DOCDIR})
  +# INSTALL(FILES
  +#     AUTHORS ChangeLog COPYING LICENSE README README_BIN README.WIN
  +#     DESTINATION ${CMAKE_INSTALL_DOCDIR})
  
  # Install man pages
  -INSTALL(FILES ${GEOTIFF_MAN_PAGES} DESTINATION ${CMAKE_INSTALL_MANDIR}/man1)
  +# INSTALL(FILES ${GEOTIFF_MAN_PAGES} DESTINATION ${CMAKE_INSTALL_MANDIR}/man1)
  
  # Install header files for development distribution
  @@ -291,7 +291,7 @@ ADD_LIBRARY(${GEOTIFF_LIBRARY_TARGET}
   ${GEOTIFF_LIB_SOURCES} ${XTIFF_SOURCES})
  
  IF(WIN32 AND MSVC)
  -    SET_TARGET_PROPERTIES(${GEOTIFF_LIBRARY_TARGET} PROPERTIES IMPORT_SUFFIX "_i.lib")
  +    SET_TARGET_PROPERTIES(${GEOTIFF_LIBRARY_TARGET} PROPERTIES IMPORT_SUFFIX ".lib")
  ENDIF(WIN32 AND MSVC)
  
  # Unix, linux:
  @@ -334,12 +334,13 @@ target_include_directories(
  PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>
        $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)

-INSTALL( TARGETS ${GEOTIFF_LIBRARY_TARGET} +INSTALL(TARGETS ${GEOTIFF_LIBRARY_TARGET} EXPORT depends

• RUNTIME DESTINATION ${CMAKE_INSTALLL_BINDIR}

• RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} ) +INSTALL(FILES $<TARGET_PDB_FILE:${GEOTIFF_LIBRARY_TARGET}> DESTINATION ${CMAKE_INSTALL_BINDIR} OPTIONAL)

  Install libgeotiff.pc

  set(prefix "${CMAKE_INSTALL_PREFIX}")

[rouault]

Fyi, here is my CMake patch (Windows build)

1.7.3 has just been released with the CMAKE_INSTALLL_BINDIR typo fix. Regardig your patch, you may want to check about other concurrent CMake changes done in https://github.com/OSGeo/libgeotiff/pull/115